You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "tejaslodayadd (via GitHub)" <gi...@apache.org> on 2026/10/15 19:46:34 UTC
[PR] CASSGO-137: Honor ConnectTimeout during TLS handshakes [cassandra-gocql-driver]
tejaslodayadd opened a new pull request, #1970:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1970
A peer that accepts TCP connections but stalls the TLS handshake can block connection setup indefinitely: ConnectTimeout bounds TCP dialing, while the handshake uses a caller context that can have no deadline.
Apply one ConnectTimeout deadline across TCP dialing and the TLS handshake in the default host dialer, including when a custom Dialer is configured. Preserve earlier caller deadlines and custom HostDialer behavior. Document the timeout scope and add regression coverage for stalled handshakes, connection cleanup, nonpositive timeouts, and successful TLS and plain connections.
Issue: https://issues.apache.org/jira/browse/CASSGO-137
Validation:
- The stalled-handshake regression fails against unchanged trunk and passes with this patch.
- Race-enabled unit suites pass with Go 1.25.12 and Go 1.26.8, excluding TestQueryMultinodeWithMetrics and TestSpeculativeExecution. Both also fail on unchanged trunk on this macOS host because 127.0.0.2 is unavailable.
- make check and lint for changed code pass. Unit-tag lint reports an existing goimports issue in frame_test.go, reproduced on unchanged trunk.
- Integration tests compile; execution against Cassandra remains to be verified in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org