You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/08/19 11:28:47 UTC
[GitHub] [pinot] aesteve opened a new issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
aesteve opened a new issue #7337:
URL: https://github.com/apache/pinot/issues/7337
The documentation [here](https://docs.pinot.apache.org/basics/data-import/complex-type#infer-the-pinot-schema-from-the-avro-schema-and-json-data) mentions the following command:
```
bin/pinot-admin.sh JsonToPinotSchema -timeColumnName hoursSinceEpoch -jsonFile //tmp/test/test.json -pinotSchemaName json-schema -outputDir /tmp/test -unnestFields=payload.commits
```
Which throws the following error:
```
Error: "-timeColumnName" is not a valid option
```
By reading the comments on [this PR](https://github.com/apache/pinot/pull/6930):
```
We already deprecated the TIME field, change it to -dateTimeColumns?
```
So I guess this should be the way to use it: using `-dateTimeColumns`.
I'll give this a try (and pass multiple columns).
If it's indeed this, then I guess only the doc is wrong, but I couldn't find where to change it. Is this in another repository?
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7337:
URL: https://github.com/apache/pinot/issues/7337#issuecomment-905851041
Made a change to the `JsonToPinotSchema` tool to take `-timeColumnName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] singh-abhijeet commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
Posted by GitBox <gi...@apache.org>.
singh-abhijeet commented on issue #7337:
URL: https://github.com/apache/pinot/issues/7337#issuecomment-905441562
Please update pinot-admin CLI error message as well, it still errors `Error: "-timeColumnName" is not a valid option`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7337:
URL: https://github.com/apache/pinot/issues/7337#issuecomment-905774838
@yupeng9 Please take a look at this PR which changes the option name for `JsonToPinotSchema` tool: #7366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] aesteve commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
Posted by GitBox <gi...@apache.org>.
aesteve commented on issue #7337:
URL: https://github.com/apache/pinot/issues/7337#issuecomment-903674371
`dateTimeColumnName` works.
Should I close? Or are you tracking the issue for updating the pinot-admin CLI help?
Thanks anyway, it works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7337:
URL: https://github.com/apache/pinot/issues/7337#issuecomment-905763271
Actually, we should probably rename the option to make it consistent with `AvroSchemaToPinotSchema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7337:
URL: https://github.com/apache/pinot/issues/7337#issuecomment-905761348
@singh-abhijeet The error message is correct because `-timeColumnName` is not a valid option, and you should use `-dateTimeColumnName` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7337:
URL: https://github.com/apache/pinot/issues/7337#issuecomment-902316020
The argument should be `-dateTimeColumnName`. Updated the PR description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang closed issue #7337:
URL: https://github.com/apache/pinot/issues/7337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org