You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/11/07 04:53:00 UTC
[GitHub] [orc] deshanxiao opened a new pull request, #1309: ORC-1308: Avoid star import
deshanxiao opened a new pull request, #1309:
URL: https://github.com/apache/orc/pull/1309
### What changes were proposed in this pull request?
This PR is aimed to avoid importing all classes from a package or static members from a class leads.
### Why are the changes needed?
For codestyle:
After the PR, stat import will be forbidden as following:
- class imports like import java.util.*;
- static member imports like import static org.junit.Assert.*;.
https://checkstyle.sourceforge.io/config_imports.html#AvoidStarImport
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1309: ORC-1308: Add `AvoidStarImport` checkstyle rule
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1309:
URL: https://github.com/apache/orc/pull/1309#issuecomment-1306503016
@deshanxiao . You can add multiple emails to GitHub account. For example, if you add `deshanxiao@microsoft.com` to your GitHub account as a secondary, the commit log will show your profile image properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #1309: ORC-1308: Add `AvoidStarImport` checkstyle rule
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #1309: ORC-1308: Add `AvoidStarImport` checkstyle rule
URL: https://github.com/apache/orc/pull/1309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1309: ORC-1308: Add `AvoidStarImport` checkstyle rule
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1309:
URL: https://github.com/apache/orc/pull/1309#issuecomment-1306110357
cc @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1309: ORC-1308: Add `AvoidStarImport` checkstyle rule
Posted by GitBox <gi...@apache.org>.
deshanxiao commented on PR #1309:
URL: https://github.com/apache/orc/pull/1309#issuecomment-1306554067
> @deshanxiao . You can add multiple emails to GitHub account. For example, if you add `deshanxiao@microsoft.com` to your GitHub account as a secondary, the commit log will show your profile image properly.
>
> 
@dongjoon-hyun Thank you, I add it and it looks well now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org