[GitHub] [cloudstack] aleskxyz commented on a change in pull request #4873: Fix no "data-server" DNS record for VPC router

[GitBox <gi...@apache.org>]

aleskxyz commented on a change in pull request #4873:
URL: https://github.com/apache/cloudstack/pull/4873#discussion_r603188584



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
##########
@@ -127,6 +127,9 @@ def configure_server(self):
                 listen_address.append(gateway)
             else:
                 listen_address.append(ip)
+            # Add localized "data-server" records in /etc/hosts for VPC routers
+            if self.config.is_vpc():
+                self.add_host(gateway, "%s data-server" % CsHelper.get_hostname())

Review comment:
       > this can only work if we know for sure that `CsHelper.get_hostname()` gives an ip address and no hostname, are we?
   
   @DaanHoogland 
   `CsHelper.get_hostname()` gives the hostname of virtual router. As you can see in screenshot, 'r-24-VM' is the hostname. So it should return hostname, not IP.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org