You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Scott Wegner (JIRA)" <ji...@apache.org> on 2018/05/24 15:35:00 UTC
[jira] [Commented] (BEAM-4375) Gradle doesn't run tests under
RunWith(Enclosed.class)
[ https://issues.apache.org/jira/browse/BEAM-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489227#comment-16489227 ]
Scott Wegner commented on BEAM-4375:
------------------------------------
This is fixed in [https://github.com/apache/beam/pull/5440] by removing the {{@RunWith(Enclosed.class)}} annotation.
> Gradle doesn't run tests under RunWith(Enclosed.class)
> ------------------------------------------------------
>
> Key: BEAM-4375
> URL: https://issues.apache.org/jira/browse/BEAM-4375
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Eugene Kirpichov
> Assignee: Scott Wegner
> Priority: Blocker
> Fix For: 2.5.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at the produced test report, one can see that it is missing tests that have RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc.
>
> This is very very bad - some of these tests are already known to be (silently) broken.
>
> Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency measure, let's convert to top-level classes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)