You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/03/02 08:36:22 UTC

[GitHub] [inlong] fuweng11 commented on a diff in pull request #7482: [INLONG-7479][Manager] Forbidden to configure stream when group configuration fails

fuweng11 commented on code in PR #7482:
URL: https://github.com/apache/inlong/pull/7482#discussion_r1122753236


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/listener/queue/StreamQueueResourceListener.java:
##########
@@ -83,6 +85,9 @@ public ListenerResult listen(WorkflowContext context) throws WorkflowListenerExc
             log.error(msg);
             throw new WorkflowListenerException(msg);
         }
+        GroupStatus groupStatus = GroupStatus.forCode(groupInfo.getStatus());
+        Preconditions.expectTrue(GroupStatus.CONFIG_FAILED != groupStatus,

Review Comment:
   This doesn't need to be set, it doesn't get thrown out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org