You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2016/10/06 00:06:03 UTC
[7/8] kudu git commit: KUDU-1669. Java ITClient test can orphan
processes
KUDU-1669. Java ITClient test can orphan processes
This removes the interruption of threads, which is the reason why we were orphaning
processes (in the ChaosThread).
Change-Id: I0085323ba9ea544488c6ce896d8627f24ea69f4b
Reviewed-on: http://gerrit.cloudera.org:8080/4598
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/3c33847f
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/3c33847f
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/3c33847f
Branch: refs/heads/master
Commit: 3c33847fc5f70ab6d65fa2fe93d5bde185e4365e
Parents: 98130e3
Author: Jean-Daniel Cryans <jd...@apache.org>
Authored: Wed Oct 5 14:40:39 2016 -0700
Committer: Jean-Daniel Cryans <jd...@apache.org>
Committed: Wed Oct 5 23:36:45 2016 +0000
----------------------------------------------------------------------
.../src/test/java/org/apache/kudu/client/ITClient.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/3c33847f/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
----------------------------------------------------------------------
diff --git a/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java b/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
index 1ff242d..13fae25 100644
--- a/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
+++ b/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
@@ -116,8 +116,8 @@ public class ITClient extends BaseKuduTest {
KEEP_RUNNING_LATCH.countDown();
for (Thread thread : threads) {
- thread.interrupt();
- thread.join();
+ // Give plenty of time for threads to stop.
+ thread.join(DEFAULT_SLEEP);
}
AsyncKuduScanner scannerBuilder = localAsyncClient.newScannerBuilder(table).build();
@@ -166,7 +166,6 @@ public class ITClient extends BaseKuduTest {
}
KEEP_RUNNING_LATCH.await(5, TimeUnit.SECONDS);
} catch (InterruptedException e) {
- e.printStackTrace();
return;
}