[jira] [Commented] (MSHARED-826) Require Java 7

["Maarten Mulders (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHARED-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857455#comment-16857455 ] 

Maarten Mulders commented on MSHARED-826:
-----------------------------------------

Currently,  {{OsTest.java}} fails on Java 12 because it alters System properties. I don't see how we could fix that without touching {{Os.java}} itself. Its Javadoc says that it got copied over from Apache ANT. It appears to me that today in ANT, this class has the same testability issues as it has in Maven.

So what do we want to do? Refactor the class to make it easier to test? Or accept that test coverage drops?

> Require Java 7
> --------------
>
>                 Key: MSHARED-826
>                 URL: https://issues.apache.org/jira/browse/MSHARED-826
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-shared-utils
>            Reporter: Maarten Mulders
>            Assignee: Robert Scholte
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> While working on [MSHARED-822|https://issues.apache.org/jira/browse/MSHARED-822] I noticed that this project still has {{maven.compiler.source}} and {{maven.compiler.target}} on 1.6.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)