[GitHub] [skywalking] wu-sheng commented on a change in pull request #4736: Increase Vert.x Compatability

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4736:
URL: https://github.com/apache/skywalking/pull/4736#discussion_r417708663



##########
File path: apm-sniffer/apm-sdk-plugin/vertx-plugins/vertx-core-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/vertx3/HttpClientRequestImplEndInterceptor.java
##########
@@ -40,11 +40,17 @@ public void onConstruct(EnhancedInstance objInst, Object[] allArguments) {
         String host;
         int port;
         if (allArguments[3] instanceof Integer) {
+            //ver. 3.0.x - 3.3.x

Review comment:
       This is an HTTP interceptor, I think `instanceof` is acceptable. Only remind you, using witness class to different versions is better. Because it has no payload at the runtime, even in the JDK8 `instanceof` is faster, but at least nothing is faster :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org