[GitHub] [maven-resolver] michael-o commented on pull request #272: [MRESOLVER-346] Too eager locking in resolver

["michael-o (via GitHub)" <gi...@apache.org>]

michael-o commented on PR #272:
URL: https://github.com/apache/maven-resolver/pull/272#issuecomment-1496416435

   > The locking in resolver is too eager. This PR relaxes locking by introducing use of shared locks (not used before) and following changes:
   > 
   >     * installer -- no change, remains exclusive locking
   > 
   >     * deployer -- laxed to shared locking, as it only reads local repo
   > 
   >     * A and M resolver -- implemented "upgrade", they are optimistic and start with shared lock (and will happily finish if local repo has all) but will "upgrade" to exclusive if remote access (hence local caching) is about to happen.
   > 
   >     * syncContext adapter -- do not "hold" on acquired locks if one fails, but release all/retry all
   > 
   > 
   > Best viewed with whitespace ignore, as there are not much change but blocks got nested.
   > 
   > https://issues.apache.org/jira/browse/MRESOLVER-346
   
   So far, you explanation sounds reasonable to me. Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org