You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/04/13 19:18:20 UTC

[Impala-ASF-CR] [tools] Comment out empty export

Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18677 )

Change subject: [tools] Comment out empty export
......................................................................


Patch Set 3: Code-Review+1

I'm using zsh and hit this a lot.
Either of commenting it like this, or wrapping it with branch detecting shell type is not zsh is fine to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/18677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I288281704480e1564a27984d5e23a54fd39b5570
Gerrit-Change-Number: 18677
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 13 Apr 2023 19:18:20 +0000
Gerrit-HasComments: No