[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #432: [ISSUE #367] Support prototype spi instance

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #432:
URL: https://github.com/apache/incubator-eventmesh/pull/432#discussion_r670077176



##########
File path: eventmesh-spi/src/test/java/org/apache/eventmesh/spi/EventMeshExtensionFactoryTest.java
##########
@@ -17,13 +17,24 @@
 
 package org.apache.eventmesh.spi;
 
+import org.apache.eventmesh.spi.example.TestPrototypeExtension;
+import org.apache.eventmesh.spi.example.TestSingletonExtension;
+import org.junit.Assert;
 import org.junit.Test;
 
 public class EventMeshExtensionFactoryTest {
 
     @Test
-    public void getExtension() {
-        TestExtension extensionA = EventMeshExtensionFactory.getExtension(TestExtension.class, "extensionA");
-        extensionA.hello();
+    public void getSingletonExtensionTest() {

Review comment:
       Yes, you are right. I will fix tonight.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org