You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/27 07:30:24 UTC
[GitHub] [dubbo] hadley0828 commented on a change in pull request #8026: add a new method for getting the number of consumer service addresses…
hadley0828 commented on a change in pull request #8026:
URL: https://github.com/apache/dubbo/pull/8026#discussion_r716428158
##########
File path: dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/util/ServiceCheckUtils.java
##########
@@ -59,4 +59,24 @@ public static int getConsumerAddressNum(ConsumerModel consumerModel) {
}
return num;
}
+
+ //for the situation that QoS wants to query the address number of a consumer in all Registries
+ public static int getConsumerAddressNumInAllRegistries(ConsumerModel consumerModel){
Review comment:
I raised this issue inspired by this "TODO" comment, thinking about there is some conditions that we need to check all registries.
And this "getConsumerAddressNum" method is called two times in the whole project. So I think it makes sense that I added a equal-functional method which is for checking all registry here. But I don't know how to call this method meaningfully at the moment.
Anyway, if you guys think this method is redundant in version 2.7.15, feel free to close this issue. Hope Dubbo can be better and better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org