[jira] [Commented] (FLINK-4636) AbstractCEPPatternOperator fails to restore state

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532937#comment-15532937 ] 

ASF GitHub Bot commented on FLINK-4636:
---------------------------------------

GitHub user jaxbihani opened a pull request:

    https://github.com/apache/flink/pull/2568

    [FLINK-4636] Add boundary check for priorityqueue for cep operator

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    When numberPriorityQueueEntries=0, creation of priority queue object
    fails as its constructor throws exception when size is passed as 0.
    We check for this condition and skip creating object as it doesn't serve
    any purpose in that case.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaxbihani/flink fix-abstractcep-op-restore-state

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2568.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2568
    
----
commit 0b7c58b911e7942a4894c631d04de0d7944c6508
Author: Jagadish Bihani <ja...@helpshift.com>
Date:   2016-09-29T14:29:38Z

    [FLINK-4636] Add boundary check for priorityqueue for cep operator
    
    When numberPriorityQueueEntries=0, creation of priority queue object
    fails as its constructor throws exception when size is passed as 0.
    We check for this condition and skip creating object as it doesn't serve
    any purpose in that case.

----


> AbstractCEPPatternOperator fails to restore state
> -------------------------------------------------
>
>                 Key: FLINK-4636
>                 URL: https://issues.apache.org/jira/browse/FLINK-4636
>             Project: Flink
>          Issue Type: Bug
>          Components: CEP
>    Affects Versions: 1.2.0, 1.1.2
>            Reporter: Fabian Hueske
>             Fix For: 1.2.0, 1.1.3
>
>
> The {{restoreState()}} of the {{AbstractCEPPatternOperator}} restores the a Java {{PriorityQueue}}. For that it first reads the number of elements to insert and then creates a {{PriorityQueue}} object. However, Java's {{PriorityQueue}} cannot be instantiated with an initial capacity of {{0}}, which is not checked.
> In case of an empty queue, the {{PriorityQueue}} should be instantiated with an initial size of {{1}}.
> See http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Problem-with-CEPPatternOperator-when-taskmanager-is-killed-tp9024.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)