[GitHub] feng-tao edited a comment on issue #4612: [AIRFLOW-3785] Decommission airflow/contrib/auth/backends

[GitBox <gi...@apache.org>]

feng-tao edited a comment on issue #4612: [AIRFLOW-3785] Decommission airflow/contrib/auth/backends
URL: https://github.com/apache/airflow/pull/4612#issuecomment-459041879
 
 
   @XD-DENG , I would suggest we do it in multiple small PRs instead of one single giant PR which is to help us to revert in case anything happens.
   
   In terms of this pr, I think FAB supports LDAP / OATH authentication(https://flask-appbuilder.readthedocs.io/en/latest/security.html#supported-authentication-types) which has been used by our company's superset service in production. Hence I think we could remove those. For password_auth, I think it is worth to check in the email alias and see if anyone still depends on it. If it turns out that many people are still using it, we should refactor for FAB's  ab_user table. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services