You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "wForget (via GitHub)" <gi...@apache.org> on 2024/03/29 02:19:00 UTC
[PR] [GLUTEN-5192][VL] Copy bundle jars to dist dir [incubator-gluten]
wForget opened a new pull request, #5193:
URL: https://github.com/apache/incubator-gluten/pull/5193
## What changes were proposed in this pull request?
closes #5192
## How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5192][VL] Copy bundle jars to dist dir [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5193:
URL: https://github.com/apache/incubator-gluten/pull/5193#issuecomment-2026487628
https://github.com/apache/incubator-gluten/issues/5192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5192][VL] Copy bundle jars to dist dir [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5193:
URL: https://github.com/apache/incubator-gluten/pull/5193#issuecomment-2116479419
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5192][VL] Copy bundle jars to dist dir [incubator-gluten]
Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #5193:
URL: https://github.com/apache/incubator-gluten/pull/5193#discussion_r1547034640
##########
dev/package.sh:
##########
@@ -4,17 +4,28 @@ set -eux
CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
GLUTEN_DIR="$CURRENT_DIR/.."
-THIRDPARTY_LIB="$GLUTEN_DIR/package/target/thirdparty-lib"
+DISTDIR="$GLUTEN_DIR/dist"
+THIRDPARTY_LIB="$DISTDIR/thirdparty-lib"
Review Comment:
Thanks, there seems to be no more documentation, just a commented script..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5192][VL] Copy bundle jars to dist dir [incubator-gluten]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #5193:
URL: https://github.com/apache/incubator-gluten/pull/5193#discussion_r1545913358
##########
dev/package.sh:
##########
@@ -4,17 +4,28 @@ set -eux
CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd)
GLUTEN_DIR="$CURRENT_DIR/.."
-THIRDPARTY_LIB="$GLUTEN_DIR/package/target/thirdparty-lib"
+DISTDIR="$GLUTEN_DIR/dist"
+THIRDPARTY_LIB="$DISTDIR/thirdparty-lib"
Review Comment:
I guess there are some docs should be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5192][VL] Copy bundle jars to dist dir [incubator-gluten]
Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget closed pull request #5193: [GLUTEN-5192][VL] Copy bundle jars to dist dir
URL: https://github.com/apache/incubator-gluten/pull/5193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5192][VL] Copy bundle jars to dist dir [incubator-gluten]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #5193:
URL: https://github.com/apache/incubator-gluten/pull/5193#discussion_r1545914069
##########
dev/buildbundle-veloxbe.sh:
##########
@@ -4,7 +4,19 @@ BASEDIR=$(dirname $0)
source "$BASEDIR/builddeps-veloxbe.sh"
cd $GLUTEN_DIR
+
+DISTDIR="$GLUTEN_DIR/dist"
+rm -rf "$DISTDIR"
+mkdir -p "$DISTDIR"
+
mvn clean package -Pbackends-velox -Prss -Pspark-3.2 -DskipTests
+cp package/target/gluten-*-bundle-spark*.jar "$DISTDIR"
Review Comment:
should we use `mv` ? It will make binary size bigger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5192][VL] Copy bundle jars to dist dir [incubator-gluten]
Posted by "wForget (via GitHub)" <gi...@apache.org>.
wForget commented on code in PR #5193:
URL: https://github.com/apache/incubator-gluten/pull/5193#discussion_r1547032753
##########
dev/buildbundle-veloxbe.sh:
##########
@@ -4,7 +4,19 @@ BASEDIR=$(dirname $0)
source "$BASEDIR/builddeps-veloxbe.sh"
cd $GLUTEN_DIR
+
+DISTDIR="$GLUTEN_DIR/dist"
+rm -rf "$DISTDIR"
+mkdir -p "$DISTDIR"
+
mvn clean package -Pbackends-velox -Prss -Pspark-3.2 -DskipTests
+cp package/target/gluten-*-bundle-spark*.jar "$DISTDIR"
Review Comment:
> should we use `mv` ? It will make binary size bigger
The `package/target` directory is just the mvn build output directory of `package` module, I think we don't need to care about its size, it will be cleaned after `mvn clean`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org