You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/03/18 17:21:31 UTC

Re: [PR] Suppress self update for windows CI runner [arrow-datafusion]

alamb commented on code in PR #9661:
URL: https://github.com/apache/arrow-datafusion/pull/9661#discussion_r1528968488


##########
.github/actions/setup-windows-builder/action.yaml:
##########
@@ -38,8 +38,7 @@ runs:
     - name: Setup Rust toolchain
       shell: bash
       run: |
-        rustup update stable
-        rustup toolchain install stable
+        rustup toolchain install stable --no-self-update

Review Comment:
   I think it helps to give some context about the rationale for certain changes (so 
   they are less likely to get lost in refactors):
   
   ```suggestion
           # Avoid self update to avoid CI failures: https://github.com/apache/arrow-datafusion/issues/9653
           rustup toolchain install stable --no-self-update
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org