You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "rawwar (via GitHub)" <gi...@apache.org> on 2024/11/27 17:32:19 UTC

[PR] minor FastAPI tests fixes [airflow]

rawwar opened a new pull request, #44429:
URL: https://github.com/apache/airflow/pull/44429

   I noticed few minor issues in tests and this PR fixes it:
   
   - Wrong param
   - trailing slashes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] minor FastAPI tests fixes [airflow]

Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on code in PR #44429:
URL: https://github.com/apache/airflow/pull/44429#discussion_r1861048419


##########
tests/api_fastapi/core_api/routes/public/test_plugins.py:
##########
@@ -56,7 +56,8 @@ class TestGetConnections:
     def test_should_respond_200(
         self, test_client, session, query_params, expected_total_entries, expected_names
     ):
-        response = test_client.get("/public/plugins/", params=query_params)
+        # breakpoint()

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] minor FastAPI tests fixes [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #44429:
URL: https://github.com/apache/airflow/pull/44429


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org