You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "gharris1727 (via GitHub)" <gi...@apache.org> on 2023/04/12 20:27:05 UTC
[GitHub] [kafka] gharris1727 opened a new pull request, #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest
gharris1727 opened a new pull request, #13549:
URL: https://github.com/apache/kafka/pull/13549
It appears that raftManager can become null via ControllerServer.shutdown() -> ensureNotRaftLeader() and various call sites of stop(). Rather than emit an NPE, evaluate raftManager.client while it is known to be non-null, and pass the evaluated client into the setHighWaterMarkAccessor.
I unfortunately don't have much context here, and I'm not sure if once raftManager becomes null, if it is still reasonable to evaluate highWatermark(), or whether the HighWaterMarkAccessor should return empty.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gharris1727 commented on pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #13549:
URL: https://github.com/apache/kafka/pull/13549#issuecomment-1505884041
@cmccabe Could you review this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gharris1727 closed pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 closed pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest
URL: https://github.com/apache/kafka/pull/13549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] gharris1727 commented on pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on PR #13549:
URL: https://github.com/apache/kafka/pull/13549#issuecomment-1506006379
This duplicates #13543 so I'll close this in favor of that more comprehensive change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe commented on PR #13549:
URL: https://github.com/apache/kafka/pull/13549#issuecomment-1506025212
Thanks @gharris1727 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org