You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/08/10 15:43:45 UTC
[GitHub] [cordova-ios] jancabadaj opened a new pull request, #1245: (iOS) Avoid repetitive permission prompts
jancabadaj opened a new pull request, #1245:
URL: https://github.com/apache/cordova-ios/pull/1245
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
resolves #1166
### Description
<!-- Describe your changes in detail -->
If the app uses WebRTC, the user is initially prompted for permission twice, and then prompted again each time the app is restarted.
The solution is inspired by react:
https://github.com/react-native-webview/react-native-webview/pull/2257
### Testing
<!-- Please describe in detail how you tested your changes. -->
I tested the changes in a project that is using WebRTC camera streaming.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "erikramalho (via GitHub)" <gi...@apache.org>.
erikramalho commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2463213864
Please, merge it guys!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2463315809
## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1245?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 80.86%. Comparing base [(`18a80d2`)](https://app.codecov.io/gh/apache/cordova-ios/commit/18a80d248c180be4d375bbe3d5e05a3a38e44cf1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3a46e22`)](https://app.codecov.io/gh/apache/cordova-ios/commit/3a46e22dea69178cf52138ddac5508c54434d6d5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1245 +/- ##
=======================================
Coverage 80.86% 80.86%
=======================================
Files 16 16
Lines 1840 1840
=======================================
Hits 1488 1488
Misses 352 352
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1245?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "erikramalho (via GitHub)" <gi...@apache.org>.
erikramalho commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2419377214
please merge it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "jancabadaj (via GitHub)" <gi...@apache.org>.
jancabadaj commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2546418292
Yes, that is correct. There is still an initial permission request, but once the app has permission, any site can access the webcam and microphone with "grant".
In our use case that is exactly what we need, since we are taking a photo from a website within iframe, but I agree that "grantIfSameHostElsePrompt" might be better as default. I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue merged PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2549089466
> Do we have an estimated release date for version 8.0.0?
@erikramalho No estimated release date because it's entirely dependent on volunteer time to investigate and address the remaining bugs and new features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "phyr0s (via GitHub)" <gi...@apache.org>.
phyr0s commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2255746246
Yes please merge it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2543023714
Thanks for doing the work to implement this!
With the "grant by default" behaviour, does that mean things like 3rd party iframes on a page would automatically be able to initiate webcam and microphone access? If so, I don't think we can have it that permissive by default.
A reasonable middle ground would probably be the "grantIfSameHostElsePrompt" behaviour so that the app's same-origin content can access those APIs but any 3rd party origins would result in a prompt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] vbraun commented on pull request #1245: (iOS) Avoid repetitive permission prompts
Posted by "vbraun (via GitHub)" <gi...@apache.org>.
vbraun commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-1442173684
Works for me, for what its worth!
I would consider setting the default to "grant" because nobody wants the repeated permission request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "agm (via GitHub)" <gi...@apache.org>.
agm commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2255699891
Please merge to avoid all related workarounds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "erikramalho (via GitHub)" <gi...@apache.org>.
erikramalho commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2548773578
Do we have an estimated release date for version 8.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "erikramalho (via GitHub)" <gi...@apache.org>.
erikramalho commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2549202701
Thanks for the answer @dpogue. I'll ask my team to look and see if we can help with any remaining bugs and new features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]
Posted by "jancabadaj (via GitHub)" <gi...@apache.org>.
jancabadaj commented on PR #1245:
URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2463212400
I fixed merge issues and changed default to 'grant' as suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org