You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/05/17 23:01:00 UTC
[jira] [Commented] (GEODE-6733) Remove mutable static
org.apache.geode.internal.net.Buffers.buffersQueue
[ https://issues.apache.org/jira/browse/GEODE-6733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842794#comment-16842794 ]
ASF subversion and git services commented on GEODE-6733:
--------------------------------------------------------
Commit a1b95388c76522be199ebb50d8b455e0e6411f3c in geode's branch refs/heads/feature/GEODE-6733 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=a1b9538 ]
GEODE-6733 Remove mutable static org.apache.geode.internal.net.Buffers.buffersQueue
Converted static Buffers class to be a non-static buffer pool.
> Remove mutable static org.apache.geode.internal.net.Buffers.buffersQueue
> ------------------------------------------------------------------------
>
> Key: GEODE-6733
> URL: https://issues.apache.org/jira/browse/GEODE-6733
> Project: Geode
> Issue Type: Sub-task
> Components: core
> Reporter: Robert Houghton
> Assignee: Bruce Schuchardt
> Priority: Major
>
> Changes to Geode have caused unit test ordering to shift in such a way that NioPlainEngineTest:ensureWrappedCapacity fails because the static Buffers.buffersQueue object is not empty at test time.
> Solution:
> Refactor the Buffers class to be non-static, and owned by its consumers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)