You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/05/19 01:23:22 UTC
Review Request 34378: Fixed the dependency between 'summarize' and
'model'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34378/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
Since `summarize` captures the important fields of an object, `model` will always be a superset of it.
We can see that `model(const Framework&)` calls `summarize(const Framework&)` and augments additional fields.
This patch removes the unnecessary forward declaration and makes `model(const Slave&)` depend on `summarize(const Slave&)` instead.
Diffs
-----
src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e
Diff: https://reviews.apache.org/r/34378/diff/
Testing
-------
make check
Thanks,
Michael Park
Re: Review Request 34378: Fixed the dependency between 'summarize' and
'model'.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34378/#review84494
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On May 19, 2015, 1:23 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34378/
> -----------------------------------------------------------
>
> (Updated May 19, 2015, 1:23 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since `summarize` captures the important fields of an object, `model` will always be a superset of it.
> We can see that `model(const Framework&)` calls `summarize(const Framework&)` and augments additional fields.
>
> This patch removes the unnecessary forward declaration and makes `model(const Slave&)` depend on `summarize(const Slave&)` instead.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e
>
> Diff: https://reviews.apache.org/r/34378/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 34378: Fixed the dependency between 'summarize' and
'model'.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34378/#review84241
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On May 18, 2015, 11:23 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34378/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 11:23 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since `summarize` captures the important fields of an object, `model` will always be a superset of it.
> We can see that `model(const Framework&)` calls `summarize(const Framework&)` and augments additional fields.
>
> This patch removes the unnecessary forward declaration and makes `model(const Slave&)` depend on `summarize(const Slave&)` instead.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e
>
> Diff: https://reviews.apache.org/r/34378/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 34378: Fixed the dependency between 'summarize' and
'model'.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34378/#review84252
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34378]
All tests passed.
- Mesos ReviewBot
On May 18, 2015, 11:23 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34378/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 11:23 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since `summarize` captures the important fields of an object, `model` will always be a superset of it.
> We can see that `model(const Framework&)` calls `summarize(const Framework&)` and augments additional fields.
>
> This patch removes the unnecessary forward declaration and makes `model(const Slave&)` depend on `summarize(const Slave&)` instead.
>
>
> Diffs
> -----
>
> src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e
>
> Diff: https://reviews.apache.org/r/34378/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Michael Park
>
>