You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:14:16 UTC
[GitHub] [skywalking] EvanLjp commented on a change in pull request #5777: Fixed unit of time mixing problem in kubernetes-client
EvanLjp commented on a change in pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777#discussion_r516451461
##########
File path: oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer = factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, 300,
Review comment:
Follow the Kubernetes default configuration
##########
File path: oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer = factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE, params.resourceVersion, 300,
Review comment:
https://github.com/apache/skywalking/issues/5778
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org