[GitHub] [incubator-doris] liutang123 commented on a change in pull request #1931: Support segment zone map

[GitBox <gi...@apache.org>]

liutang123 commented on a change in pull request #1931: Support segment zone map
URL: https://github.com/apache/incubator-doris/pull/1931#discussion_r332482523
 
 

 ##########
 File path: gensrc/proto/segment_v2.proto
 ##########
 @@ -91,8 +91,10 @@ message ColumnMetaPB {
     optional bool is_nullable = 6;
     // ordinal index page
     optional PagePointerPB ordinal_index_page = 7;
-    // zone map page
+    // zone map page of zone maps in page granularity
     optional PagePointerPB zone_map_page = 8;
+    // zone map in segment granularity
+    optional ZoneMapPB zone_map = 10;
 
 Review comment:
   `zone_map` is a field of `ColumnMetaPB`. Is `column_zone_map ` really better than `zone_map`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org