You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/10/13 19:02:13 UTC

[GitHub] spark pull request #20560: [SPARK-23375][SQL] Eliminate unneeded Sort in Opt...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20560#discussion_r224969136
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala ---
    @@ -64,7 +64,8 @@ case class InMemoryRelation(
         tableName: Option[String])(
         @transient var _cachedColumnBuffers: RDD[CachedBatch] = null,
         val sizeInBytesStats: LongAccumulator = child.sqlContext.sparkContext.longAccumulator,
    -    statsOfPlanToCache: Statistics)
    +    statsOfPlanToCache: Statistics,
    +    override val outputOrdering: Seq[SortOrder])
    --- End diff --
    
    This should be added to `otherCopyArgs `; otherwise, we will lose it when doing the tree transformation. https://github.com/apache/spark/pull/22715 fixed it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org