You are viewing a plain text version of this content. The canonical link for it is here.
Posted to legal-discuss@apache.org by "Jarek Potiuk (Jira)" <ji...@apache.org> on 2022/01/27 08:59:00 UTC
[jira] [Commented] (LEGAL-599) Using GitHub's "Merge Queue" functionality
[ https://issues.apache.org/jira/browse/LEGAL-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482985#comment-17482985 ]
Jarek Potiuk commented on LEGAL-599:
------------------------------------
Fully agree with [~MartijnVisser] assesment on usefulness of the Merge Queue. Apache Airflow could benefit from that as well. And having protected branches with approvals is IMHO enough to fulfill the ASF policies expectations.
One comment to that - by seing this issue (thanks Martin!) It sparked a thought about consequences of a blog entry from GitHub that I just saw - GitHub just patched a loophole (that we were all not aware of) in Github Actions configuration - by default GitHub Actions **can** approve PRs and such PRs would count towards the minimum approval count. They intrduced a feature that allows to disable it 14th of Jan [https://github.blog/changelog/2022-01-14-github-actions-prevent-github-actions-from-approving-pull-requests/] so as long we disable it in ASF, we should be safe.
In order to disable it, it needs an action from the INFRA. I opened https://issues.apache.org/jira/browse/INFRA-22801 to disable it.
> Using GitHub's "Merge Queue" functionality
> ------------------------------------------
>
> Key: LEGAL-599
> URL: https://issues.apache.org/jira/browse/LEGAL-599
> Project: Legal Discuss
> Issue Type: Question
> Reporter: Martijn Visser
> Priority: Major
>
> Recently GitHub has announced the limited beta of their "Pull Request Merge Queue" functionality. More information can be found at https://github.blog/changelog/2021-10-27-pull-request-merge-queue-limited-beta/
> This seems like an interesting functionality for a lot of ASF projects, given that there are a lot of projects that have a high volume of changes from multiple users being merged every day. For example, the Apache Flink project is in this situation.
> This functionality does create temporary branches for the queues. Given the discussion around Dependabot, I'm wondering what the ASF thinks of this feature and if it could potentially be enabled for ASF projects. For context, I've opened https://issues.apache.org/jira/browse/LEGAL-589 last month to get clarification on Dependabot and creating branches in ASF repos. Given that resolution, I would expect that this functionality could also be allowed under the same conditions, but I wanted to get confirmation from Legal upfront.
> (Note: I've posted this question in November on the users@infra.apache.org mailing list. There are other ASF projects who are also interested in this.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: legal-discuss-unsubscribe@apache.org
For additional commands, e-mail: legal-discuss-help@apache.org