You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/05/30 10:07:14 UTC

[GitHub] [fineract] galovics commented on a diff in pull request #2340: Enable/Disable Messaging in Read Only instance mode

galovics commented on code in PR #2340:
URL: https://github.com/apache/fineract/pull/2340#discussion_r884658074


##########
fineract-provider/src/main/java/org/apache/fineract/notification/config/MessagingConfiguration.java:
##########
@@ -35,6 +36,7 @@
 
 @Configuration
 @Profile("activeMqEnabled")
+@ConditionalOnExpression("${fineract.mode.write-enabled:true} || ${fineract.mode.batch-enabled:true}")

Review Comment:
   I wish we could use programmatic conditions here with the FineractModeProperties POJO.
   
   Before merging, please look at this: https://stackoverflow.com/a/69901997/2863995
   And let's try to make it work.
   
   @taskain7 already created a programmatic Condition here: `FineractModeValidationCondition`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org