You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2025/06/16 10:17:18 UTC
[PR] perf(make_idempotent): improve performance of idempotent writes by reducing deserialization and removing the mapping table for atomic write handlers [incubator-pegasus]
empiredan opened a new pull request, #2261:
URL: https://github.com/apache/incubator-pegasus/pull/2261
https://github.com/apache/incubator-pegasus/issues/2197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] perf(make_idempotent): improve performance of idempotent writes by reducing deserialization and removing the mapping table for atomic write handlers [incubator-pegasus]
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #2261:
URL: https://github.com/apache/incubator-pegasus/pull/2261#discussion_r2159144485
##########
src/rpc/rpc_holder.h:
##########
@@ -224,9 +224,13 @@ class rpc_holder
dsn_rpc_forward(dsn_request(), addr);
}
- inline void set_auto_reply(bool auto_reply) { _i->auto_reply = auto_reply; }
+ [[nodiscard]] inline bool is_auto_reply() const { return _i->auto_reply; }
- inline void enable_auto_reply() { set_auto_reply(true); }
+ inline void set_auto_reply(bool auto_reply) const { _i->auto_reply = auto_reply; }
Review Comment:
Can it be private?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] perf(make_idempotent): improve performance of idempotent writes by reducing deserialization and removing the mapping table for atomic write handlers [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #2261:
URL: https://github.com/apache/incubator-pegasus/pull/2261#discussion_r2160936054
##########
src/rpc/rpc_holder.h:
##########
@@ -224,9 +224,13 @@ class rpc_holder
dsn_rpc_forward(dsn_request(), addr);
}
- inline void set_auto_reply(bool auto_reply) { _i->auto_reply = auto_reply; }
+ [[nodiscard]] inline bool is_auto_reply() const { return _i->auto_reply; }
- inline void enable_auto_reply() { set_auto_reply(true); }
+ inline void set_auto_reply(bool auto_reply) const { _i->auto_reply = auto_reply; }
Review Comment:
Yes, currently we've never called `set_auto_reply()` externally. So it could be made private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
Re: [PR] perf(make_idempotent): improve performance of idempotent writes by reducing deserialization and removing the mapping table for atomic write handlers [incubator-pegasus]
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan merged PR #2261:
URL: https://github.com/apache/incubator-pegasus/pull/2261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org