[jira] [Commented] (SOLR-14391) Remove getDocSet's manual doc collection logic; remove ScoreFilter

["David Smiley (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138858#comment-17138858 ] 

David Smiley commented on SOLR-14391:
-------------------------------------

[~shalin] as 8.6 approaches; is this here a major concern (un-benchmarked change) that you think I should revert in 8.x?  Other things seem more important so I haven't prioritized benchmarking this.  Personally it seems low-risk to me.  My objective in this issue was about tech-debt -- I'm eliminating uses of Filter bit by bit.

[~ichattopadhyaya] I'm looking forward to seeing the benchmark suite you are workin on.

> Remove getDocSet's manual doc collection logic; remove ScoreFilter
> ------------------------------------------------------------------
>
>                 Key: SOLR-14391
>                 URL: https://issues.apache.org/jira/browse/SOLR-14391
>             Project: Solr
>          Issue Type: Task
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 8.6
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {{SolrIndexSearcher.getDocSet(List<Query>)}} calls getProcessedFilter and then basically loops over doc IDs, passing them through the filter, and passes them to the Collector.  This logic is redundant with what Lucene searcher.search(query,collector) will ultimately do in BulkScorer, and so I propose we remove all that code and delegate to Lucene.
> Also, the top of this method looks to see if any query implements the "ScoreFilter" marker interface (only implemented by CollapsingPostFilter) and if so delegates to {{getDocSetScore}} method instead.  That method has an implementation close to what I propose getDocSet be changed to; so it can be removed along with this ScoreFilter interface searcher.search(query,collector).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org