You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mahesh Reddy (Code Review)" <ge...@cloudera.org> on 2025/01/15 04:03:19 UTC

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Hello Alexey Serbin, Abhishek Chennaka,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/22352

to review the following change.


Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................

KUDU-613: Fix heap-use-after-free bug

The last patch submitted to make the segment-level
metrics more relevant introduced a bug where an
entry was accessed after it was deleted. This patch
fixes that behavior by accessing the entry before
it is deleted.

Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Reviewed-on: http://gerrit.cloudera.org:8080/22343
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 75b75ca2f58f1a5aba69207830e3558011033d99)
---
M src/kudu/util/slru_cache.cc
1 file changed, 8 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/22352/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Patch Set 2: -Verified

Build Started http://jenkins.kudu.apache.org/job/pre_commit/931/


-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2025 08:20:14 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/929/


-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2025 04:04:20 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2025 04:05:29 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/929/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2025 06:00:28 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................

KUDU-613: Fix heap-use-after-free bug

The last patch submitted to make the segment-level
metrics more relevant introduced a bug where an
entry was accessed after it was deleted. This patch
fixes that behavior by accessing the entry before
it is deleted.

Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Reviewed-on: http://gerrit.cloudera.org:8080/22343
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 75b75ca2f58f1a5aba69207830e3558011033d99)
Reviewed-on: http://gerrit.cloudera.org:8080/22352
---
M src/kudu/util/slru_cache.cc
1 file changed, 8 insertions(+), 10 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Patch Set 2: Verified+1

unexpected test failures (TSAN): known flaky tests


-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2025 16:26:49 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/928/


-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2025 04:03:26 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Patch Set 1:

Build Aborted 

http://jenkins.kudu.apache.org/job/pre_commit/928/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2025 04:04:14 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.18.x) KUDU-613: Fix heap-use-after-free bug

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22352 )

Change subject: KUDU-613: Fix heap-use-after-free bug
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/931/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f91d0984b017861ded5f1bd30fddfa29588f9aa
Gerrit-Change-Number: 22352
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Jan 2025 10:59:26 +0000
Gerrit-HasComments: No