[GitHub] [couchdb] iilyak commented on a change in pull request #3889: Handle libicu upgrades in views

[GitBox <gi...@apache.org>]

iilyak commented on a change in pull request #3889:
URL: https://github.com/apache/couchdb/pull/3889#discussion_r802617910



##########
File path: src/couch/test/eunit/couchdb_views_tests.erl
##########
@@ -161,24 +182,85 @@ backup_restore_test_() ->
         }
     }.
 
-upgrade_test_() ->
+upgrade_2x_test_() ->
+    {
+        "Upgrade 2x tests",
+        {
+            setup,
+            fun test_util:start_couch/0,
+            fun test_util:stop_couch/1,
+            {
+                foreach,
+                fun setup_legacy_2x/0,
+                fun teardown_legacy/1,
+                [
+                    fun should_upgrade_legacy_2x_view_files/1
+                ]
+            }
+        }
+    }.
+
+upgrade_321_test_() ->

Review comment:
       Small nitpick. `321` -> `3_2_1`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org