[GitHub] [netbeans] sdedic commented on a change in pull request #3262: [NETBEANS-5847] Maven project template uses template for project structure.

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #3262:
URL: https://github.com/apache/netbeans/pull/3262#discussion_r740140643



##########
File path: java/java.lsp.server/nbcode/integration/src/org/netbeans/modules/nbcode/integration/layer.xml
##########
@@ -39,7 +39,7 @@
             </folder>
             <file name="Import_hidden"/>
             <folder name="Maven2">
-                <file name="JavaApplication_hidden"/>
+                <file name="maven.archetype_hidden"/>

Review comment:
       Hm. I thought that `maven.archetype` was a way how to allow LSP to create a project. This is now replaced by the `JavaApplication2` template.
   
   Re. rename: that's a question how to handle such situation: the original template is a **file**. I need to provide a folder structure, so:
   * the template can be no longer a **file**, but must turn to a folder. Existing installations or extensions that may have contributed to that file in the ConfigFS would break (impossible to layer-merge file + folder).
   * a new template will be introduced, which I did (JavaApplication2).
   * a "contents here" attribute will be introduced. So the project itself can continue as **file** template, but its contents will be elsewhere. I even made code support for it, but at the end decided not to use it in the template.
   
   Please share your thoughts.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists