You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/17 04:07:02 UTC
[GitHub] [incubator-nuttx] YuuichiNakamura commented on a change in pull
request #811: Fix saved %esp value in up_saveusercontext() for qemu-i486
YuuichiNakamura commented on a change in pull request #811: Fix saved %esp value in up_saveusercontext() for qemu-i486
URL: https://github.com/apache/incubator-nuttx/pull/811#discussion_r409981069
##########
File path: arch/x86/src/qemu/qemu_saveusercontext.S
##########
@@ -132,16 +132,16 @@ up_saveusercontext:
* EIP
* CS ...
* EFLAGS EIP
- * -> ESP CS
+ * ESP CS
* ESP->Return address SS EFLAGS
- * Argument Argument Argument
+ * Argument -> Argument Argument
Review comment:
Saved %esp must point here. Because up_fullcontextrestore creates the IRET stack frame after restoring %esp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services