[GitHub] eolivelli commented on a change in pull request #1572: Use readExplicitLAC instead of readEntry in order to get current LastAddConfirmed

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1572: Use readExplicitLAC instead of readEntry in order to get current LastAddConfirmed
URL: https://github.com/apache/bookkeeper/pull/1572#discussion_r244383633
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
 ##########
 @@ -1335,6 +1335,14 @@ synchronized void updateLastConfirmed(long lac, long len) {
      */
 
     public void asyncReadLastConfirmed(final ReadLastConfirmedCallback cb, final Object ctx) {
+        if (clientCtx.getConf().useExplicitLacForReads) {
 
 Review comment:
   Maybe the name is misleading but it is already here.
   This function will compose explicit and piggybacked LAC.
   So actually it would be better to use always readExplicitLAC RPC, but we cannot enable it by default because it works only with recent bookies and with v3 protocol

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services