You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2011/09/01 19:41:11 UTC
[jira] [Commented] (THRIFT-1217) Use evutil_socketpair instead of
pipe (Windows port)
[ https://issues.apache.org/jira/browse/THRIFT-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095462#comment-13095462 ]
Hudson commented on THRIFT-1217:
--------------------------------
Integrated in Thrift #245 (See [https://builds.apache.org/job/Thrift/245/])
THRIFT-1305. cpp: make TConnection a private inner class of
TNonblockingServer
The previous patch reverted some elements of THRIFT-1217. Fixed.
Patch: Alexandre Parenteau
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1164161
Files :
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.h
> Use evutil_socketpair instead of pipe (Windows port)
> ----------------------------------------------------
>
> Key: THRIFT-1217
> URL: https://issues.apache.org/jira/browse/THRIFT-1217
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.6.1, 0.7
> Environment: Windows C++ 9.0, 10.0
> Reporter: alexandre parenteau
> Priority: Minor
> Labels: patch
> Fix For: 0.7
>
> Attachments: evutil_socketpair.txt, thrift-1217.patchv0.2.txt
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> As part of an effort to use the Non-Blocking server (using libevent) on Windows, it was necessary to remove the use of "pipe" for the notification mechanism to signal end-of-task. We propose to use evutil_socketpair instead (tested with libevent 2.0.12). Patch included. Please see https://github.com/aubonbeurre/thrift/blob/alex-0.6.1/README.non.blocking.Windows for more details.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira