You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by anthony shaw <an...@gmail.com> on 2015/08/26 13:19:30 UTC
[dev] Contributing again
Hey
Just a couple of quick ones, I'm working on a few features for the dimension data driver namely support for a loadbalancing driver and extending the compute to support more functions and the newer API.
1. I understand the branching requirements are referencing a Jira ticket. Do you create a ticket per feature and a feature branch? I've gone down that path with 736 and LIBCLOUD-7372. Unit tests. The existing tests were mock http results, which I've extended coverage for. Do any of the other drivers utilise a real http request? What is the expected level of coverage on the driver?
3. What is the plan for a networking driver? Along the lines of the openstack systems
Ant
Sent from Outlook
Re: [dev] Contributing again
Posted by anthony shaw <an...@gmail.com>.
I think I picked the wrong approach by creating 2 branches, since after the
first one got merged, the second raised (easily resolvable) merge conflicts.
https://github.com/apache/libcloud/pull/567
The new load balancer driver is all done anyway, I've created and tested
about 25 production load balancers and the code performs pretty well. A
testament to the library I think!
xml.etree is pretty clunky, but it does the job.
Ant
On Thu, Aug 27, 2015 at 2:51 AM, Tomaz Muraus <to...@apache.org> wrote:
> Replies are in-line.
>
> On Wed, Aug 26, 2015 at 2:33 PM, anthony shaw <an...@gmail.com>
> wrote:
>
> > That makes sense..
> >
> > I completed the first PR anyway, #564 and the code refactoring to a
> common
> > connection class and model classes is coming in the second PR.
> >
>
> Sounds good.
>
>
> > Networking driver looks like a good start, whether people are wanting to
> > leverage ACLs, security groups and other items from the neutron
> extensions
> > APIs would be a thought.
> >
> > Does anyone know who the biggest users of this library are? I'm aware of
> > mist.io and some other dev shops using it. I know python-novaclient is
> > popular for purely OS/Nova and jclouds for people like abiquo.
> >
>
> Some other users besides mist.io include DivvyCloud, SixSq and
> CloudControl
> (they use it inside their products to talk to different cloud providers).
> More complete list can be found at
> https://libcloud.apache.org/whois-using.html.
>
> Besides companies listed on this page, many other companies also use it
> internally to provision and manage their cloud resources.
>
>
> > On Wed, Aug 26, 2015 at 9:48 PM, Tomaz Muraus <to...@apache.org> wrote:
> >
> > > Hi,
> > >
> > > Replies are in-line.
> > >
> > > On Wed, Aug 26, 2015 at 1:19 PM, anthony shaw <
> anthony.p.shaw@gmail.com>
> > > wrote:
> > >
> > > > Hey
> > > > Just a couple of quick ones, I'm working on a few features for the
> > > > dimension data driver namely support for a loadbalancing driver and
> > > > extending the compute to support more functions and the newer API.
> > > >
> > >
> > >
> > > > 1. I understand the branching requirements are referencing a Jira
> > ticket.
> > > > Do you create a ticket per feature and a feature branch? I've gone
> down
> > > > that path with 736 and LIBCLOUD-7372.
> > >
> > >
> > > Yes, we follow "feature branch" approach. In your case it would be
> ideal
> > to
> > > submit two PRs - one for new loadbalancing driver and one for compute
> > > driver improvements.
> > >
> > > In case those features are related and share a lot of code (e.g. you
> are
> > > going to refactor some shared code in a common module), then it's OK to
> > > just open a single PR.
> > >
> > >
> > > > Unit tests. The existing tests were mock http results, which I've
> > > extended
> > > > coverage for. Do any of the other drivers utilise a real http
> request?
> > > What
> > > > is the expected level of coverage on the driver?
> > > >
> > >
> > > None of the drivers right now use real HTTP requests since testing
> > against
> > > a real provider API is quite hard (especially emulating all the edge
> > cases,
> > > etc.).
> > >
> > > As far as the expected coverage level goes - we have a no fixed number
> > > requirement, but the more the better :)
> > >
> > >
> > > > 3. What is the plan for a networking driver? Along the lines of the
> > > > openstack systems
> > > >
> > >
> > > I started to work on this in the past (
> > > https://github.com/apache/libcloud/pull/345), but sadly I didn't have
> > the
> > > time to finish it.
> > >
> > > It would be great if someone could pick it up.
> > >
> > >
> > > >
> > > > Ant
> > > > Sent from Outlook
> > >
> >
>
Re: [dev] Contributing again
Posted by Tomaz Muraus <to...@apache.org>.
Replies are in-line.
On Wed, Aug 26, 2015 at 2:33 PM, anthony shaw <an...@gmail.com>
wrote:
> That makes sense..
>
> I completed the first PR anyway, #564 and the code refactoring to a common
> connection class and model classes is coming in the second PR.
>
Sounds good.
> Networking driver looks like a good start, whether people are wanting to
> leverage ACLs, security groups and other items from the neutron extensions
> APIs would be a thought.
>
> Does anyone know who the biggest users of this library are? I'm aware of
> mist.io and some other dev shops using it. I know python-novaclient is
> popular for purely OS/Nova and jclouds for people like abiquo.
>
Some other users besides mist.io include DivvyCloud, SixSq and CloudControl
(they use it inside their products to talk to different cloud providers).
More complete list can be found at
https://libcloud.apache.org/whois-using.html.
Besides companies listed on this page, many other companies also use it
internally to provision and manage their cloud resources.
> On Wed, Aug 26, 2015 at 9:48 PM, Tomaz Muraus <to...@apache.org> wrote:
>
> > Hi,
> >
> > Replies are in-line.
> >
> > On Wed, Aug 26, 2015 at 1:19 PM, anthony shaw <an...@gmail.com>
> > wrote:
> >
> > > Hey
> > > Just a couple of quick ones, I'm working on a few features for the
> > > dimension data driver namely support for a loadbalancing driver and
> > > extending the compute to support more functions and the newer API.
> > >
> >
> >
> > > 1. I understand the branching requirements are referencing a Jira
> ticket.
> > > Do you create a ticket per feature and a feature branch? I've gone down
> > > that path with 736 and LIBCLOUD-7372.
> >
> >
> > Yes, we follow "feature branch" approach. In your case it would be ideal
> to
> > submit two PRs - one for new loadbalancing driver and one for compute
> > driver improvements.
> >
> > In case those features are related and share a lot of code (e.g. you are
> > going to refactor some shared code in a common module), then it's OK to
> > just open a single PR.
> >
> >
> > > Unit tests. The existing tests were mock http results, which I've
> > extended
> > > coverage for. Do any of the other drivers utilise a real http request?
> > What
> > > is the expected level of coverage on the driver?
> > >
> >
> > None of the drivers right now use real HTTP requests since testing
> against
> > a real provider API is quite hard (especially emulating all the edge
> cases,
> > etc.).
> >
> > As far as the expected coverage level goes - we have a no fixed number
> > requirement, but the more the better :)
> >
> >
> > > 3. What is the plan for a networking driver? Along the lines of the
> > > openstack systems
> > >
> >
> > I started to work on this in the past (
> > https://github.com/apache/libcloud/pull/345), but sadly I didn't have
> the
> > time to finish it.
> >
> > It would be great if someone could pick it up.
> >
> >
> > >
> > > Ant
> > > Sent from Outlook
> >
>
Re: [dev] Contributing again
Posted by anthony shaw <an...@gmail.com>.
That makes sense..
I completed the first PR anyway, #564 and the code refactoring to a common
connection class and model classes is coming in the second PR.
Networking driver looks like a good start, whether people are wanting to
leverage ACLs, security groups and other items from the neutron extensions
APIs would be a thought.
Does anyone know who the biggest users of this library are? I'm aware of
mist.io and some other dev shops using it. I know python-novaclient is
popular for purely OS/Nova and jclouds for people like abiquo.
On Wed, Aug 26, 2015 at 9:48 PM, Tomaz Muraus <to...@apache.org> wrote:
> Hi,
>
> Replies are in-line.
>
> On Wed, Aug 26, 2015 at 1:19 PM, anthony shaw <an...@gmail.com>
> wrote:
>
> > Hey
> > Just a couple of quick ones, I'm working on a few features for the
> > dimension data driver namely support for a loadbalancing driver and
> > extending the compute to support more functions and the newer API.
> >
>
>
> > 1. I understand the branching requirements are referencing a Jira ticket.
> > Do you create a ticket per feature and a feature branch? I've gone down
> > that path with 736 and LIBCLOUD-7372.
>
>
> Yes, we follow "feature branch" approach. In your case it would be ideal to
> submit two PRs - one for new loadbalancing driver and one for compute
> driver improvements.
>
> In case those features are related and share a lot of code (e.g. you are
> going to refactor some shared code in a common module), then it's OK to
> just open a single PR.
>
>
> > Unit tests. The existing tests were mock http results, which I've
> extended
> > coverage for. Do any of the other drivers utilise a real http request?
> What
> > is the expected level of coverage on the driver?
> >
>
> None of the drivers right now use real HTTP requests since testing against
> a real provider API is quite hard (especially emulating all the edge cases,
> etc.).
>
> As far as the expected coverage level goes - we have a no fixed number
> requirement, but the more the better :)
>
>
> > 3. What is the plan for a networking driver? Along the lines of the
> > openstack systems
> >
>
> I started to work on this in the past (
> https://github.com/apache/libcloud/pull/345), but sadly I didn't have the
> time to finish it.
>
> It would be great if someone could pick it up.
>
>
> >
> > Ant
> > Sent from Outlook
>
Re: [dev] Contributing again
Posted by Tomaz Muraus <to...@apache.org>.
Hi,
Replies are in-line.
On Wed, Aug 26, 2015 at 1:19 PM, anthony shaw <an...@gmail.com>
wrote:
> Hey
> Just a couple of quick ones, I'm working on a few features for the
> dimension data driver namely support for a loadbalancing driver and
> extending the compute to support more functions and the newer API.
>
> 1. I understand the branching requirements are referencing a Jira ticket.
> Do you create a ticket per feature and a feature branch? I've gone down
> that path with 736 and LIBCLOUD-7372.
Yes, we follow "feature branch" approach. In your case it would be ideal to
submit two PRs - one for new loadbalancing driver and one for compute
driver improvements.
In case those features are related and share a lot of code (e.g. you are
going to refactor some shared code in a common module), then it's OK to
just open a single PR.
> Unit tests. The existing tests were mock http results, which I've extended
> coverage for. Do any of the other drivers utilise a real http request? What
> is the expected level of coverage on the driver?
>
None of the drivers right now use real HTTP requests since testing against
a real provider API is quite hard (especially emulating all the edge cases,
etc.).
As far as the expected coverage level goes - we have a no fixed number
requirement, but the more the better :)
> 3. What is the plan for a networking driver? Along the lines of the
> openstack systems
>
I started to work on this in the past (
https://github.com/apache/libcloud/pull/345), but sadly I didn't have the
time to finish it.
It would be great if someone could pick it up.
>
> Ant
> Sent from Outlook