You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/02 21:25:34 UTC

[GitHub] [cordova-ios] ath0mas opened a new pull request #1133: Update Readme: Xcode and clean

ath0mas opened a new pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Reviewing Readme between cordova-ios and cordova-android.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Fix typo and add "Debugging in Xcode".
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   .
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu edited a comment on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923739978


   As for @NiklasMerz comment
   
   > You can also open the PROJECTNAME.xcodeproj or ``PROJECTNAME.xcodeworkspace` files in the platforms folder.
   
   IMO, if you want to add this to the README, only suggest opening the `xcodeworkspace` and not mention the option for `xcodeproj`.
   
   If my memory is correct, there were issues in the past when opening `xcodeproj`. E.g. within XCode the CordovaLib might not have loaded and there were reference issues. But right now it seems OK...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu commented on a change in pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#discussion_r688375379



##########
File path: README.md
##########
@@ -7,9 +7,9 @@
 # to you under the Apache License, Version 2.0 (the
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
-# 
+#

Review comment:
       ```suggestion
   # 
   ```
   Revert

##########
File path: README.md
##########
@@ -47,20 +47,24 @@ cordova platform add --link /path/to/cordova-ios
 
 ## Updating a Cordova project
 
-When you install a new `cordova-cli` version that comes with a new iOS platform version, from within your project:
+When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`Cordova-iOS`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:
 
 ```bash
 cordova platform rm ios
 cordova platform add ios
 ```
 
+## Debugging in Xcode
+
+Import project in Xcode through _File > Open_ and targeting `/path/to/your-cdv-project/platforms/ios/`.

Review comment:
       ```suggestion
   Import project in Xcode through _File > Open_ and targeting `/path/to/your-cdv-project/platforms/ios/PROJECT_NAME.xcodeworkspace`.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu merged pull request #1133: doc: readme improvements (cleaup, xcode debugging, etc)

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu commented on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923784600


   OK, I have remembered it now and confirmed,
   
   If a user is installing a plugin that uses Pods, opening the `xcodeproj` will not load the Pods as it is a separate project. Then, the code that tries to import the pods will fail and therefore the build fails.
   
   If the project contains Pods, the users should open `xcworkspace`.
   
   This is why I always suggested to people to open the `xcworkspace`. If we mentioned anything about `xcodeproj` including why not to open it because its nuances could lead to confusion.
   
   If anything is mentioned, just the `xcworkspace` is fine.
   
   Here is also an example screenshot of the XCode project navigator to show the difference.
   
   | xcworkspace | xcodeproj |
   | -- | -- |
   | <img width="260" alt="xcworkspace" src="https://user-images.githubusercontent.com/1029107/134143738-47849f66-6ac2-4952-90dc-2c4633c540cf.png"> | <img width="344" alt="xcodeproj" src="https://user-images.githubusercontent.com/1029107/134143783-770bb37b-49ee-4719-aa91-d4fc28646e58.png"> |
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #1133: doc: readme improvements (cleaup, xcode debugging, etc)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923428820


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1133](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b305a3) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7a4f7c3311c05baefc1271cb75145d5d29e8bd84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a4f7c3) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 9b305a3 differs from pull request most recent head 1a5a583. Consider uploading reports for the commit 1a5a583 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/1133/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1133   +/-   ##
   =======================================
     Coverage   74.86%   74.86%           
   =======================================
     Files          13       13           
     Lines        1723     1723           
   =======================================
     Hits         1290     1290           
     Misses        433      433           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7a4f7c3...1a5a583](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on a change in pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#discussion_r706956510



##########
File path: README.md
##########
@@ -7,9 +7,9 @@
 # to you under the Apache License, Version 2.0 (the
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
-# 
+#

Review comment:
       I'd avoid making changes to the LICENSE blurps... we have scripts that scans files and this may trip a complaint. Not sure if these run on markdown files or not... but better safe than sorry.

##########
File path: README.md
##########
@@ -47,20 +47,24 @@ cordova platform add --link /path/to/cordova-ios
 
 ## Updating a Cordova project
 
-When you install a new `cordova-cli` version that comes with a new iOS platform version, from within your project:
+When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`Cordova-iOS`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:

Review comment:
       I think it's better to reference `Cordova-iOS` as the package name literally, `cordova-ios`, which also makes this consistent with other parts of the docs, such as:
   
   > link the appropriate cordova-ios platform folder path:
   
   ```suggestion
   When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`cordova-ios`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:
   ```

##########
File path: README.md
##########
@@ -7,9 +7,9 @@
 # to you under the Apache License, Version 2.0 (the
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
-# 
+#
 # http://www.apache.org/licenses/LICENSE-2.0
-# 
+#

Review comment:
       same as above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter commented on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923428820


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1133](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fe2c2b) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7a4f7c3311c05baefc1271cb75145d5d29e8bd84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a4f7c3) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/1133/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1133   +/-   ##
   =======================================
     Coverage   74.86%   74.86%           
   =======================================
     Files          13       13           
     Lines        1723     1723           
   =======================================
     Hits         1290     1290           
     Misses        433      433           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7a4f7c3...7fe2c2b](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu edited a comment on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923784600


   OK, I have remembered it now and confirmed,
   
   If a user is installing a plugin that uses Pods, opening the `xcodeproj` will not load the Pods as it is a separate project. And then, the code that imports the pods will fail and leads to build failures.
   
   If the project contains Pods, the users should open `xcworkspace`.
   
   This is why I always suggested to people to open the `xcworkspace`. If we mentioned anything about `xcodeproj` including why not to open it because its nuances could lead to confusion.
   
   If anything is mentioned, just the `xcworkspace` is fine.
   
   Here is also an example screenshot of the XCode project navigator to show the difference.
   
   | xcworkspace | xcodeproj |
   | -- | -- |
   | <img width="260" alt="xcworkspace" src="https://user-images.githubusercontent.com/1029107/134143738-47849f66-6ac2-4952-90dc-2c4633c540cf.png"> | <img width="344" alt="xcodeproj" src="https://user-images.githubusercontent.com/1029107/134143783-770bb37b-49ee-4719-aa91-d4fc28646e58.png"> |
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu commented on a change in pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#discussion_r720631853



##########
File path: README.md
##########
@@ -47,20 +47,24 @@ cordova platform add --link /path/to/cordova-ios
 
 ## Updating a Cordova project
 
-When you install a new `cordova-cli` version that comes with a new iOS platform version, from within your project:
+When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`Cordova-iOS`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:
 
 ```bash
 cordova platform rm ios
 cordova platform add ios
 ```
 
+## Debugging in Xcode
+
+Import project in Xcode through _File > Open_ and targeting `/path/to/your-cdv-project/platforms/ios/PROJECT_NAME.xcodeworkspace`.

Review comment:
       ```suggestion
   Import project in Xcode through _File > Open_ and targeting `/path/to/your-cdv-project/platforms/ios/PROJECT_NAME.xcworkspace`.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu edited a comment on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923784600


   OK, I have remembered it now and confirmed,
   
   If a user is installing a plugin that uses Pods, opening the `xcodeproj` will not load the Pods as it is a separate project. And then, the code that imports the pods will fail and leads to build failures.
   
   If the project contains Pods, the users should open `xcworkspace`.
   
   This is why I always suggested to people to open the `xcworkspace`. `xcworkspace` works for all cases.
   
   If we mentioned anything about `xcodeproj`, it could lead to confusion.
   
   If anything is mentioned, just the `xcworkspace` is fine.
   
   Here is also an example screenshot of the XCode project navigator to show the difference.
   
   | xcworkspace | xcodeproj |
   | -- | -- |
   | <img width="260" alt="xcworkspace" src="https://user-images.githubusercontent.com/1029107/134143738-47849f66-6ac2-4952-90dc-2c4633c540cf.png"> | <img width="344" alt="xcodeproj" src="https://user-images.githubusercontent.com/1029107/134143783-770bb37b-49ee-4719-aa91-d4fc28646e58.png"> |
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] ath0mas commented on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-902270424


   I just applied the same changes suggested and merged by @erisu in linked PR for cdv-android.
   
   Ready for review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] ath0mas commented on a change in pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
ath0mas commented on a change in pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#discussion_r711788185



##########
File path: README.md
##########
@@ -7,9 +7,9 @@
 # to you under the Apache License, Version 2.0 (the
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
-# 
+#

Review comment:
       Done

##########
File path: README.md
##########
@@ -7,9 +7,9 @@
 # to you under the Apache License, Version 2.0 (the
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
-# 
+#
 # http://www.apache.org/licenses/LICENSE-2.0
-# 
+#

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] ath0mas commented on a change in pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
ath0mas commented on a change in pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#discussion_r711788949



##########
File path: README.md
##########
@@ -47,20 +47,24 @@ cordova platform add --link /path/to/cordova-ios
 
 ## Updating a Cordova project
 
-When you install a new `cordova-cli` version that comes with a new iOS platform version, from within your project:
+When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`Cordova-iOS`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:

Review comment:
       This wording is to match with the code review changes done by @erisu in PR apache/cordova-android#1308 (see https://github.com/apache/cordova-android/pull/1308/commits/993737e0986f20893f37ebbdb864db0682ecbfc6).
   
   Do you confirm I should reword it to `cordova-ios` here? and do it too for cordova-android through a new PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] NiklasMerz commented on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923768503


   @erisu I agree. I have used both with no issues so far but we should only recommend the workspace. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923428820


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1133](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7fe2c2b) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7a4f7c3311c05baefc1271cb75145d5d29e8bd84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a4f7c3) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/1133/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1133   +/-   ##
   =======================================
     Coverage   74.86%   74.86%           
   =======================================
     Files          13       13           
     Lines        1723     1723           
   =======================================
     Hits         1290     1290           
     Misses        433      433           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7a4f7c3...7fe2c2b](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] breautek commented on a change in pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
breautek commented on a change in pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#discussion_r712584499



##########
File path: README.md
##########
@@ -47,20 +47,24 @@ cordova platform add --link /path/to/cordova-ios
 
 ## Updating a Cordova project
 
-When you install a new `cordova-cli` version that comes with a new iOS platform version, from within your project:
+When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`Cordova-iOS`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:

Review comment:
       Ah well, I'm not really sure :sweat_smile:  and I can't really find an any document to point to that defines how things should be worded/referenced.
   
   So we'll just say I'm wrong and we can follow the style as requested from Erisu.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu edited a comment on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923784600


   OK, I have remembered it now and confirmed,
   
   If a user is installing a plugin that uses Pods, opening the `xcodeproj` will not load the Pods as it is a separate project. And then, the code that imports the pods will fail and leads to build failures.
   
   If the project contains Pods, the users should open `xcworkspace`.
   
   This is why I always suggested to people to open the `xcworkspace`. `xcworkspace` works for all cases.
   
   * If we mentioned anything about `xcodeproj`, it could lead to confusion.
   * If anything is mentioned, just the `xcworkspace` is fine.
   
   Here is also an example screenshot of the XCode project navigator to show the difference.
   
   | xcworkspace | xcodeproj |
   | -- | -- |
   | <img width="260" alt="xcworkspace" src="https://user-images.githubusercontent.com/1029107/134143738-47849f66-6ac2-4952-90dc-2c4633c540cf.png"> | <img width="344" alt="xcodeproj" src="https://user-images.githubusercontent.com/1029107/134143783-770bb37b-49ee-4719-aa91-d4fc28646e58.png"> |
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] erisu commented on pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923739978


   As for @NiklasMerz comment
   
   > You can also open the PROJECTNAME.xcodeproj or ``PROJECTNAME.xcodeworkspace` files in the platforms folder.
   
   IMO, if you want to add this to the README, only suggest opening the `xcodeworkspace`. Do not mention the option for `xcodeproj` or say that opening the `xcodeproj` will lead to issues.
   
   If my memory is correct, opening the `xcodeproj` will not load the `CordovaLib` and leads to reference errors and build failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] NiklasMerz commented on a change in pull request #1133: Update Readme: Xcode and clean

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on a change in pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#discussion_r712713947



##########
File path: README.md
##########
@@ -47,20 +47,24 @@ cordova platform add --link /path/to/cordova-ios
 
 ## Updating a Cordova project
 
-When you install a new `cordova-cli` version that comes with a new iOS platform version, from within your project:
+When you install a new version of the [`Cordova CLI`](https://www.npmjs.com/package/cordova) that pins a new version of the [`Cordova-iOS`](https://www.npmjs.com/package/cordova-ios) platform, you can follow these simple upgrade steps within your project:
 
 ```bash
 cordova platform rm ios
 cordova platform add ios
 ```
 
+## Debugging in Xcode
+
+Import project in Xcode through _File > Open_ and targeting `/path/to/your-cdv-project/platforms/ios/`.

Review comment:
       You can also open the `PROJECTNAME.xcodeproj` or ``PROJECTNAME.xcodeworkspace` files in the platforms folder.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #1133: doc: readme improvements (cleaup, xcode debugging, etc)

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1133:
URL: https://github.com/apache/cordova-ios/pull/1133#issuecomment-923428820


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1133](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a5a583) into [master](https://codecov.io/gh/apache/cordova-ios/commit/7a4f7c3311c05baefc1271cb75145d5d29e8bd84?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a4f7c3) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/1133/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1133   +/-   ##
   =======================================
     Coverage   74.86%   74.86%           
   =======================================
     Files          13       13           
     Lines        1723     1723           
   =======================================
     Hits         1290     1290           
     Misses        433      433           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7a4f7c3...1a5a583](https://codecov.io/gh/apache/cordova-ios/pull/1133?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org