You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/16 03:33:49 UTC

[GitHub] [pulsar] poorbarcode opened a new pull request, #15613: [cleanup] [broker] Delete duplicate method definitions

poorbarcode opened a new pull request, #15613:
URL: https://github.com/apache/pulsar/pull/15613

   ### Motivation
   
   `NonPersistentDispatcher`'s superclass `Dispatcher` already declares exactly the same methods, so definitions of those methods are completely unnecessary.
   
   https://github.com/apache/pulsar/blob/b6351f73481fc78d8ba13f7355194c9c51dc59c4/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentDispatcher.java#L34-L50
   
   ### Modifications
   
   Delete these methods
   
   
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   - [ ] `no-need-doc` 
   - [x] `doc` 
   - [ ] `doc-added`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] poorbarcode commented on pull request #15613: [cleanup][broker] Delete duplicate method definitions

Posted by GitBox <gi...@apache.org>.

poorbarcode commented on PR #15613:
URL: https://github.com/apache/pulsar/pull/15613#issuecomment-1128361918

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #15613: [cleanup][broker] Delete duplicate method definitions

Posted by GitBox <gi...@apache.org>.

codelipenghui merged PR #15613:
URL: https://github.com/apache/pulsar/pull/15613


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org