You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/11 18:46:35 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #14178: [BEAM-9547] Implement count() on deferred DataFrame, Series

TheNeuralBit commented on a change in pull request #14178:
URL: https://github.com/apache/beam/pull/14178#discussion_r592623422



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -573,6 +573,7 @@ def axes(self):
 
   all = frame_base._agg_method('all')
   any = frame_base._agg_method('any')
+  count = frame_base._agg_method('count')

Review comment:
       I think it's correct, just suboptimal, it's deferring to `aggregate` which only lifts associative aggregations. It's using Singleton partitioning here (and for others like `mean`). I should probably go ahead and update `aggregate` to observe `LIFTABLE_WITH_SUM_AGGREGATIONS`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org