You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/03/16 23:52:38 UTC

Review Request 44938: GEODE-514 Make sure we look for quorum check only when networkPartition is enable.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44938/
-----------------------------------------------------------

Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.


Repository: geode


Description
-------

GEODE-514 Make sure we look for quorum check only when networkPartition is enable.


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java d95d8df 
  geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 2164fdc 

Diff: https://reviews.apache.org/r/44938/diff/


Testing
-------


Thanks,

Hitesh Khamesra


Re: Review Request 44938: GEODE-514 Make sure we look for quorum check only when networkPartition is enable.

Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44938/#review123949
-----------------------------------------------------------



this seems to be the wrong diff.  I was expecting to see a change to GMSJoinLeave but this has the gemfire.jg-bind-port changes.

- Bruce Schuchardt


On March 16, 2016, 10:52 p.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44938/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 10:52 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-514 Make sure we look for quorum check only when networkPartition is enable.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java d95d8df 
>   geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/DistributionManagerDUnitTest.java 2164fdc 
> 
> Diff: https://reviews.apache.org/r/44938/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>