[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #5045: fix @Tag returnedObject bug #5036

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #5045:
URL: https://github.com/apache/skywalking/pull/5045#discussion_r450617063



##########
File path: apm-sniffer/apm-toolkit-activation/apm-toolkit-trace-activation/src/main/java/org/apache/skywalking/apm/toolkit/activation/util/TagUtil.java
##########
@@ -38,6 +38,6 @@ public static void tagReturnSpanSpan(final AbstractSpan span, final Map<String,
 
     public static Boolean isReturnTag(String expression) {
         String[] es = expression.split("\\.");
-        return es.length == 2 && "returnedObj".equals(es[0]);
+        return "returnedObj".equals(es[0]);

Review comment:
       Are there possibilities that the method returns a `String` and the user wants to use that as a tag? In such case, `es.length == 1`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org