You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/05 19:15:25 UTC
(commons-dbcp) branch master updated: Make private class final
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbcp.git
The following commit(s) were added to refs/heads/master by this push:
new 4d54dc36 Make private class final
4d54dc36 is described below
commit 4d54dc36e9e61583f7fdd80978031d9bebe0a0b0
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 5 14:15:20 2023 -0500
Make private class final
---
src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java | 2 +-
src/main/java/org/apache/commons/dbcp2/PoolingDriver.java | 2 +-
.../java/org/apache/commons/dbcp2/managed/TestManagedConnection.java | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java b/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
index 7fd4104e..36cf46d2 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolingDataSource.java
@@ -46,7 +46,7 @@ public class PoolingDataSource<C extends Connection> implements DataSource, Auto
*
* @since 2.0
*/
- private class PoolGuardConnectionWrapper<D extends Connection> extends DelegatingConnection<D> {
+ private final class PoolGuardConnectionWrapper<D extends Connection> extends DelegatingConnection<D> {
PoolGuardConnectionWrapper(final D delegate) {
super(delegate);
diff --git a/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java b/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
index b4a41388..f553740f 100644
--- a/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
+++ b/src/main/java/org/apache/commons/dbcp2/PoolingDriver.java
@@ -41,7 +41,7 @@ public class PoolingDriver implements Driver {
*
* @since 2.0
*/
- private class PoolGuardConnectionWrapper extends DelegatingConnection<Connection> {
+ private final class PoolGuardConnectionWrapper extends DelegatingConnection<Connection> {
private final ObjectPool<? extends Connection> pool;
diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java
index 68390f00..31af37da 100644
--- a/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java
+++ b/src/test/java/org/apache/commons/dbcp2/managed/TestManagedConnection.java
@@ -53,7 +53,7 @@ import org.junit.jupiter.api.Test;
*/
public class TestManagedConnection {
- private class UncooperativeLocalXAConnectionFactory
+ private final class UncooperativeLocalXAConnectionFactory
extends LocalXAConnectionFactory {
public UncooperativeLocalXAConnectionFactory(final TransactionManager transactionManager, final ConnectionFactory connectionFactory) {
@@ -125,7 +125,7 @@ public class TestManagedConnection {
}
}
- private class UncooperativeTransactionRegistry
+ private final class UncooperativeTransactionRegistry
extends TransactionRegistry {
public UncooperativeTransactionRegistry(final TransactionManager transactionManager) {