You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/22 14:32:30 UTC
[GitHub] [doris] nextdreamblue opened a new pull request, #14352: [feature](show) display storage root path and medium of be by show ba…
nextdreamblue opened a new pull request, #14352:
URL: https://github.com/apache/doris/pull/14352
…ckends
Signed-off-by: nextdreamblue <zx...@163.com>
# Proposed changes
Issue Number: close #14337
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue closed pull request #14352: [feature](show) display storage root path and medium of be by show ba…
Posted by GitBox <gi...@apache.org>.
nextdreamblue closed pull request #14352: [feature](show) display storage root path and medium of be by show ba…
URL: https://github.com/apache/doris/pull/14352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #14352: [feature](show) display storage root path and medium of be by show ba…
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on PR #14352:
URL: https://github.com/apache/doris/pull/14352#issuecomment-1323770526
> We can view the path by `show proc "/backends/10001"`, where 10001 is the id of the backend. So I think we don't need to add this column to `show backends`. And there maybe many disks for a certain backends, which cause the result too long.
maybe can add a column to display medium info by `show proc "/backends/10001"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on a diff in pull request #14352: [feature](show) display storage root path and medium of be by show ba…
Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #14352:
URL: https://github.com/apache/doris/pull/14352#discussion_r1027388387
##########
fe/fe-core/src/test/java/org/apache/doris/utframe/DemoMultiBackendsTest.java:
##########
@@ -201,9 +201,10 @@ public void testCreateDbAndTable() throws Exception {
Assert.assertEquals(BackendsProcDir.TITLE_NAMES.size(), result.getColumnNames().size());
Assert.assertEquals("{\"location\" : \"default\"}", result.getRows().get(0).get(20));
Assert.assertEquals("{\"lastSuccessReportTabletsTime\":\"N/A\",\"lastStreamLoadTime\":-1,\"isQueryDisabled\":false,\"isLoadDisabled\":false}",
- result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 3));
- Assert.assertEquals("0", result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 2));
- Assert.assertEquals(Tag.VALUE_MIX, result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 1));
+ result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 4));
+ Assert.assertEquals("0", result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 3));
+ Assert.assertEquals(Tag.VALUE_MIX, result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 2));
+ Assert.assertEquals("/home/doris.SSD:SSD; /home/doris.HDD:HDD; ", result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 1));
Review Comment:
`/home/doris` Whether depends on DORIS_HOME?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on pull request #14352: [feature](show) display storage root path and medium of be by show ba…
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on PR #14352:
URL: https://github.com/apache/doris/pull/14352#issuecomment-1323767258
> We can view the path by `show proc "/backends/10001"`, where 10001 is the id of the backend. So I think we don't need to add this column to `show backends`. And there maybe many disks for a certain backends, which cause the result too long.
it is good enough by show proc "/backends/10001". this pr will colse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14352: [feature](show) display storage root path and medium of be by show ba…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14352:
URL: https://github.com/apache/doris/pull/14352#issuecomment-1322850117
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14352: [feature](show) display storage root path and medium of be by show ba…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14352:
URL: https://github.com/apache/doris/pull/14352#issuecomment-1322850081
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue closed pull request #14352: [feature](show) display storage medium of be by show proc
Posted by "nextdreamblue (via GitHub)" <gi...@apache.org>.
nextdreamblue closed pull request #14352: [feature](show) display storage medium of be by show proc
URL: https://github.com/apache/doris/pull/14352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] nextdreamblue commented on a diff in pull request #14352: [feature](show) display storage root path and medium of be by show ba…
Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on code in PR #14352:
URL: https://github.com/apache/doris/pull/14352#discussion_r1027411051
##########
fe/fe-core/src/test/java/org/apache/doris/utframe/DemoMultiBackendsTest.java:
##########
@@ -201,9 +201,10 @@ public void testCreateDbAndTable() throws Exception {
Assert.assertEquals(BackendsProcDir.TITLE_NAMES.size(), result.getColumnNames().size());
Assert.assertEquals("{\"location\" : \"default\"}", result.getRows().get(0).get(20));
Assert.assertEquals("{\"lastSuccessReportTabletsTime\":\"N/A\",\"lastStreamLoadTime\":-1,\"isQueryDisabled\":false,\"isLoadDisabled\":false}",
- result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 3));
- Assert.assertEquals("0", result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 2));
- Assert.assertEquals(Tag.VALUE_MIX, result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 1));
+ result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 4));
+ Assert.assertEquals("0", result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 3));
+ Assert.assertEquals(Tag.VALUE_MIX, result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 2));
+ Assert.assertEquals("/home/doris.SSD:SSD; /home/doris.HDD:HDD; ", result.getRows().get(0).get(BackendsProcDir.TITLE_NAMES.size() - 1));
Review Comment:
it depends on be's conf: storage_root_path
> `/home/doris` Whether depends on DORIS_HOME?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14352: [feature](show) display storage root path and medium of be by show ba…
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14352:
URL: https://github.com/apache/doris/pull/14352#issuecomment-1318254762
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.09 seconds
load time: 440 seconds
storage size: 17171603440 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221117081742_clickbench_pr_47900.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org