You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/10/03 10:41:54 UTC
Review Request 62745: SENTRY-1210 - Refactor the SentryShellSolr and
SentryShellKafka
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62745/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1210
https://issues.apache.org/jira/browse/SENTRY-1210
Repository: sentry
Description
-------
For generic model, one shell like SentryShellGeneric should be covered all related components, eg, solr, kafka. SentryShellSolr and SentryShellKafka should be replaced with the SentryShellGeneric
Diffs
-----
bin/sentryShell f0661568
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java f6e5d1b6
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java 5385f7d7
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellCommon.java 6ddc1def
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java 7db54260
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java d4e26e82
Diff: https://reviews.apache.org/r/62745/diff/1/
Testing
-------
Tested that the binary "sentryShell" can list privileges correctly for both Kafka and Solr.
Thanks,
Colm O hEigeartaigh
Re: Review Request 62745: SENTRY-1210 - Refactor the SentryShellSolr
and SentryShellKafka
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62745/#review187033
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java
Lines 110 (patched)
<https://reviews.apache.org/r/62745/#comment263988>
I think this should be more explicit and fail if the type isn't kafka or solr
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java
Lines 117 (patched)
<https://reviews.apache.org/r/62745/#comment263989>
Ditto.
- Alexander Kolbasov
On Oct. 3, 2017, 10:41 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62745/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2017, 10:41 a.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1210
> https://issues.apache.org/jira/browse/SENTRY-1210
>
>
> Repository: sentry
>
>
> Description
> -------
>
> For generic model, one shell like SentryShellGeneric should be covered all related components, eg, solr, kafka. SentryShellSolr and SentryShellKafka should be replaced with the SentryShellGeneric
>
>
> Diffs
> -----
>
> bin/sentryShell f0661568
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java f6e5d1b6
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java 5385f7d7
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellCommon.java 6ddc1def
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java 7db54260
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java d4e26e82
>
>
> Diff: https://reviews.apache.org/r/62745/diff/1/
>
>
> Testing
> -------
>
> Tested that the binary "sentryShell" can list privileges correctly for both Kafka and Solr.
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>