You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/13 22:08:21 UTC

[jira] [Commented] (RYA-178) Review RAT Exclusions

    [ https://issues.apache.org/jira/browse/RYA-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573345#comment-15573345 ] 

ASF GitHub Bot commented on RYA-178:
------------------------------------

GitHub user meiercaleb opened a pull request:

    https://github.com/apache/incubator-rya/pull/107

    RYA-178-Remove Rat Exclusions for OWL Files

    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    >What Changed?
    Removed Rat Exclusions for OWL files.
    
    ### Tests
    No new tests added.  Build passes rat check.
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-178)
    
    ### Checklist
    - [] Code Review
    - [X] Squash Commits
    
    #### People To Reivew
    Aaron Mihalik
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/meiercaleb/incubator-rya RYA-178

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #107
    
----
commit 168f6c336014967121ba5571ec38be4183f4499e
Author: Caleb Meier <ca...@parsons.com>
Date:   2016-10-13T22:04:14Z

    RYA-178-Remove Rat Exclusions for OWL Files

----


> Review RAT Exclusions
> ---------------------
>
>                 Key: RYA-178
>                 URL: https://issues.apache.org/jira/browse/RYA-178
>             Project: Rya
>          Issue Type: Task
>    Affects Versions: 3.2.10
>            Reporter: Aaron Mihalik
>            Assignee: Caleb Meier
>
> During 3.2.10-RC1 Review, Josh Noted:
> * Saw some XML files in the build which were excluded from the
> apache-rat-plugin. I'd recommend minimizing the exclusions as much as
> possible.
> * mvn apache-rat:check passes (after `rm DEPENDENCIES`)
> (Need to add DEPENDENCIES to the exclusion list)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)