You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/03/23 22:50:16 UTC
[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #715:
HDDS-3253. Initialize Recon metrics for prometheus at /prom endpoint
vivekratnavel opened a new pull request #715: HDDS-3253. Initialize Recon metrics for prometheus at /prom endpoint
URL: https://github.com/apache/hadoop-ozone/pull/715
## What changes were proposed in this pull request?
- Initialize metrics for Recon at /prom endpoint
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3253
## How was this patch tested?
- By bringing up recon via docker-compose and testing /prom endpoint at recon (localhost:9888/prom)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on issue #715: HDDS-3253.
Initialize Recon metrics for prometheus at /prom endpoint
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #715: HDDS-3253. Initialize Recon metrics for prometheus at /prom endpoint
URL: https://github.com/apache/hadoop-ozone/pull/715#issuecomment-602899211
@avijayanhwx @elek Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #715: HDDS-3253. Initialize
Recon metrics for prometheus at /prom endpoint
Posted by GitBox <gi...@apache.org>.
elek closed pull request #715: HDDS-3253. Initialize Recon metrics for prometheus at /prom endpoint
URL: https://github.com/apache/hadoop-ozone/pull/715
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request
#715: HDDS-3253. Initialize Recon metrics for prometheus at /prom endpoint
Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #715: HDDS-3253. Initialize Recon metrics for prometheus at /prom endpoint
URL: https://github.com/apache/hadoop-ozone/pull/715#discussion_r397943155
##########
File path: hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconServer.java
##########
@@ -67,6 +69,7 @@ public static void main(String[] args) {
public Void call() throws Exception {
OzoneConfiguration ozoneConfiguration = createOzoneConfiguration();
ConfigurationProvider.setConfiguration(ozoneConfiguration);
+ configuration = ozoneConfiguration;
Review comment:
Why not convert the variable in Line 72 as a field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org