You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by ziyang zhao <zi...@simba.com> on 2016/06/08 00:50:11 UTC
Review Request 48386: HIVE-13723 patch to fix Float cast to Double
bug when using Thrift Serde
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48386/
-----------------------------------------------------------
Review request for hive, Thejas Nair and Vaibhav Gumashta.
Repository: hive-git
Description
-------
In this patch, instead of set the type of float ColumnBuffer as TYPE_DOUBLE, I set it as TYPE_FLOAT, but let it go through the same process as double ColumnBuffer.
Diffs
-----
serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java 929c405
Diff: https://reviews.apache.org/r/48386/diff/
Testing
-------
None.
Thanks,
ziyang zhao
Re: Review Request 48386: HIVE-13723 patch to fix Float cast to
Double bug when using Thrift Serde
Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48386/#review136724
-----------------------------------------------------------
Ship it!
Ship It!
- Vaibhav Gumashta
On June 8, 2016, 12:50 a.m., ziyang zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48386/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 12:50 a.m.)
>
>
> Review request for hive, Thejas Nair and Vaibhav Gumashta.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> In this patch, instead of set the type of float ColumnBuffer as TYPE_DOUBLE, I set it as TYPE_FLOAT, but let it go through the same process as double ColumnBuffer.
>
>
> Diffs
> -----
>
> serde/src/java/org/apache/hadoop/hive/serde2/thrift/ColumnBuffer.java 929c405
>
> Diff: https://reviews.apache.org/r/48386/diff/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> ziyang zhao
>
>