[GitHub] [tvm] Alexey-Yazev commented on a diff in pull request #13369: [usmp] Hill Climb greedy layout size check relaxed

[GitBox <gi...@apache.org>]

Alexey-Yazev commented on code in PR #13369:
URL: https://github.com/apache/tvm/pull/13369#discussion_r1022458150


##########
src/tir/usmp/algo/hill_climb.cc:
##########
@@ -312,6 +331,14 @@ class HillClimbAllocator : public GreedyBase {
     Map<BufferInfo, PoolAllocation> result;
     // return winning combination
     for (auto it : result_pool_allocations) {
+      // post-check that everything was fit
+      const BufferInfoNode* buf = it.first;
+      const PoolAllocation& pa = it.second;
+      if (NullValue<PoolInfo>().same_as(pa->pool_info) ||
+          !IsValidPlacement(pa->pool_info, pa->byte_offset->value, buf->size_bytes->value)) {
+        std::unordered_map<PoolInfo, size_t, ObjectPtrHash, ObjectPtrEqual> m = {};
+        SelectPlacementPool(GetRef<BufferInfo>(buf), m);

Review Comment:
   maybe add an error message specifying the required memory size instead of the error message from SelectPlacementPool?



##########
tests/python/contrib/test_ethosu/test_networks.py:
##########
@@ -20,7 +20,7 @@
 pytest.importorskip("ethosu.vela")
 
 import numpy as np
-
+import tvm

Review Comment:
   on the 27th line the same import remained



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org