You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2023/08/18 23:15:58 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request, #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
nvazquez opened a new pull request, #7879:
URL: https://github.com/apache/cloudstack/pull/7879
### Description
This PR adds missing tooltips on the Register/Upload Template/ISO views:
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
- Register Template form
- Upload Template form
- Register ISO form
- Upload ISO form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1684536966
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1685950056
code lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1685315914
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache merged pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1684536244
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1685950230
verified on QA server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1684548796
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7879 (QA-JID-151)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1684568636
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7879?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7879](https://app.codecov.io/gh/apache/cloudstack/pull/7879?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (03a0ed6) into [main](https://app.codecov.io/gh/apache/cloudstack/commit/1065e9046b15360713a36c364fc25fc77fe362d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1065e90) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #7879 +/- ##
============================================
- Coverage 14.38% 14.38% -0.01%
+ Complexity 10080 10079 -1
============================================
Files 2748 2748
Lines 259062 259062
Branches 40332 40332
============================================
- Hits 37272 37264 -8
- Misses 216972 216984 +12
+ Partials 4818 4814 -4
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7879/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1685318704
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7879 (QA-JID-153)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #7879: UI: Add missing tooltips to Register/Upload Templates/ISOs views
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #7879:
URL: https://github.com/apache/cloudstack/pull/7879#issuecomment-1685315826
@DaanHoogland yes, I have rebased to the 4.18 branch now
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org