[GitHub] [spark] xuanyuanking commented on a change in pull request #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #25508: [SPARK-28699][CORE][2.3] Fix a corner case for aborting indeterminate stage
URL: https://github.com/apache/spark/pull/25508#discussion_r316032627
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
 ##########
 @@ -2521,33 +2521,19 @@ class DAGSchedulerSuite extends SparkFunSuite with LocalSparkContext with TimeLi
       (Success, makeMapStatus("hostD", 2))))
     assert(mapOutputTracker.findMissingPartitions(shuffleId2) === Some(Seq.empty))
 
+    // Simulate the scenario of executor lost
+    runEvent(ExecutorLost("exec-hostC", ExecutorKilled))
 
 Review comment:
   The behavior difference between 2.3 and 2.4 is related to #21758, which move the output status clean work forward: https://github.com/apache/spark/pull/21758/files#diff-6a9ff7fb74fd490a50462d45db2d5e11L1390.
   So I fix the behavior by simulating the executor lost because here we want a scenario of missing some partitions while rerunning the shuffle map stage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org